[Asterisk-code-review] res_pjsip_rfc3326: Q.850 reason code for CANCEL is set to AST_CAUSE_N... (asterisk[18])

[Joshua Colp]

Attention is currently required from: George Joseph, Mark Petersen.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16344 )

Change subject: res_pjsip_rfc3326: Q.850 reason code for CANCEL is set to AST_CAUSE_NORMAL_CLEARING
......................................................................


Patch Set 9: Code-Review-1

(2 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/16344/comment/6c78b1cb_bff1208b 
PS9, Line 7: res_pjsip_rfc3326: Q.850 reason code for CANCEL is set to AST_CAUSE_NORMAL_CLEARING
I think this change is now across multiple things and this commit message doesn't describe them all. You've got app_dial changes as well as res_pjsip_rfc3326.


File res/res_pjsip_rfc3326.c:

https://gerrit.asterisk.org/c/asterisk/+/16344/comment/516a2035_9fa28f51 
PS5, Line 80: 	if (ast_channel_hangupcause(session->channel) == AST_CAUSE_NOTDEFINED &&
            : 		!pjsip_method_cmp(&rdata->msg_info.msg->line.req.method, &pjsip_cancel_method)) {
            : 			ast_debug(1, "Channel '%s', setting hangup cause: %d\n", ast_channel_name(session->channel), AST_CAUSE_NORMAL_CLEARING);
            : 			ast_channel_hangupcause_set(session->channel, AST_CAUSE_NORMAL_CLEARING);
            : 	}
            : 
> it is mainly a safeguard that we only send out Q.850 if we have a legal cause code […]
I don't understand your response to this. This code isn't for sending out Q.850. It sets a default of AST_CAUSE_NORMAL_CLEARING on a channel. Do you actually mean that the result of this is then used elsewhere?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16344
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ib653aec2282f55b59d87484391cc07c8e6612b89
Gerrit-Change-Number: 16344
Gerrit-PatchSet: 9
Gerrit-Owner: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Comment-Date: Wed, 17 Nov 2021 10:55:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Comment-In-Reply-To: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211117/8aa7f5f1/attachment.html>