[Asterisk-code-review] res_tonedetect: Add call progress tone detection (asterisk[master])

Kevin Harwell asteriskteam at digium.com
Tue Nov 16 13:47:50 CST 2021


Attention is currently required from: N A.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16667 )

Change subject: res_tonedetect: Add call progress tone detection
......................................................................


Patch Set 5: Code-Review-1

(2 comments)

File res/res_tonedetect.c:

https://gerrit.asterisk.org/c/asterisk/+/16667/comment/d4266c56_9c16f157 
PS5, Line 874: 			return -1;
dsp is leaked in this path


https://gerrit.asterisk.org/c/asterisk/+/16667/comment/348beea1_69f28452 
PS5, Line 985: 	ast_dsp_free(dsp);
             : 
             : 	return 0;
dsp2 is potentially leaked if created. A free for it will need to be added too.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16667
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ia02437e0450473031e294798b8cb421fb8f24e90
Gerrit-Change-Number: 16667
Gerrit-PatchSet: 5
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Tue, 16 Nov 2021 19:47:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211116/29cf354b/attachment.html>


More information about the asterisk-code-review mailing list