[Asterisk-code-review] res_rtp: Addressing possible rtp range issues (asterisk[16])

Sean Bright asteriskteam at digium.com
Mon Nov 15 10:21:22 CST 2021


Attention is currently required from: Michael Bradeen.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16637 )

Change subject: res_rtp: Addressing possible rtp range issues
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/16637/comment/ce94fe1b_ab7fbefa 
PS2, Line 7: res_rtp: Addressing possible rtp range issues
res_rtp_asterisk: Addressing possible rtp range issues.


File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/c/asterisk/+/16637/comment/9ae65b24_0ff09ae7 
PS2, Line 3869: condiction 
s/condiction/condition/


https://gerrit.asterisk.org/c/asterisk/+/16637/comment/dfb6996b_99ced23a 
PS2, Line 3871: 	for (loopcounter = 0;loopcounter <= maxloops;loopcounter++) {
Spaces after semis. Also using 'i' would be less verbose and more idiomatic.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16637
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I90f07deef0716da4a30206e9f849458b2dbe346b
Gerrit-Change-Number: 16637
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Comment-Date: Mon, 15 Nov 2021 16:21:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211115/3fb0175f/attachment.html>


More information about the asterisk-code-review mailing list