[Asterisk-code-review] Enhance FreeBSD compilation support (asterisk[master])
N A
asteriskteam at digium.com
Sun Nov 14 20:35:51 CST 2021
Attention is currently required from: Sean Bright.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17362 )
Change subject: Enhance FreeBSD compilation support
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://gerrit.asterisk.org/c/asterisk/+/17362/comment/03d4e062_0c0b40bd
PS1, Line 7: Add FreeBSD compiler flag
> This doesn't follow commit message guidelines (I also don't understand what your patch has to do wit […]
Yeah, sorry about that, it's a bit hard to eyeball in the terminal (nano) and I guess I tend to be conservative so as not to go over ;) Used to Notepad++ showing detailed line info!
As for the format, I'm not entirely sure what category this would be, this isn't for any specific module, it's not the Makefile, and so forth, so I didn't add such a tag, but I can if there is one that should be used for this.
Patchset:
PS1:
> Can you update your jira issue with the compiler errors these changes are fixing?
Not sure about specific errors, but I've linked the actual source for these to the JIRA issue. I discussed with the port maintainer and he directed me to those in particular.
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17362
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ice4f615a9ea4662dd6d83594f0c9989e1b5251c0
Gerrit-Change-Number: 17362
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Mon, 15 Nov 2021 02:35:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211114/30d4d0f8/attachment.html>
More information about the asterisk-code-review
mailing list