[Asterisk-code-review] Add FreeBSD compiler flag (asterisk[master])

Sean Bright asteriskteam at digium.com
Sun Nov 14 14:20:54 CST 2021


Attention is currently required from: N A.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17362 )

Change subject: Add FreeBSD compiler flag
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/17362/comment/d9ba8b96_709a7625 
PS1, Line 7: Add FreeBSD compiler flag
This doesn't follow commit message guidelines (I also don't understand what your patch has to do with compiler flags, but maybe I am not understanding something).

https://wiki.asterisk.org/wiki/display/AST/Commit+Messages

The entire message is also wrapped too tightly. Shoot for 72 columns.


Patchset:

PS1: 
Can you update your jira issue with the compiler errors these changes are fixing?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17362
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ice4f615a9ea4662dd6d83594f0c9989e1b5251c0
Gerrit-Change-Number: 17362
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Sun, 14 Nov 2021 20:20:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211114/35fee192/attachment.html>


More information about the asterisk-code-review mailing list