[Asterisk-code-review] logger: use __FUNCTION__ instead of __PRETTY_FUNCTION__ (asterisk[master])

[Jaco Kroon]

Attention is currently required from: Joshua Colp.
Jaco Kroon has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16661 )

Change subject: logger: use __FUNCTION__ instead of __PRETTY_FUNCTION__
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1: 
> You mean for C++ external modules?
Yes.  For the moment I've simply done in our external module:

#undef _A_
#define _A_ __FILE__, __LINE__, __FUNCTION__

Which covers for those "calls" that utilize _A_, but not those that have __FILE__, __LINE__, __PRETTY_FUNCTION__ hard wired in the macro.  So even if you're in strong preference for keeping __PRETTY_FUNCTION__, then can we at least merge the rest of the patch that uses _A_ wherever possible, and perhaps give it a better name (__LOG_FLF__ ?)?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16661
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I54101a0bb5f8cb9ef63ec12c5e0d4c8edafff9ed
Gerrit-Change-Number: 16661
Gerrit-PatchSet: 1
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 11 Nov 2021 10:46:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Jaco Kroon <jaco at uls.co.za>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211111/4e844d7e/attachment.html>