[Asterisk-code-review] term: truncate the message rather than the escapes. (asterisk[master])

[Joshua Colp]

Attention is currently required from: Jaco Kroon.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16640 )

Change subject: term: truncate the message rather than the escapes.
......................................................................


Patch Set 3:

(1 comment)

Patchset:

PS3: 
Sean asked about this on IRC:

jkroon: i'm still not in love with it, i don't know why. i would argue that passing in a buffer that is not even large enough to contain the escape sequences would constitute programmer error.
10:46:02 AM i would like to understand when this happens in practice. what messages have you actually seen get truncated?

Is this in combination with the PRETTY_FUNCTION change and originates from C++ land?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16640
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I80ef7a4bfd2947e090ef830143391d11baebdb0d
Gerrit-Change-Number: 16640
Gerrit-PatchSet: 3
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Jaco Kroon <jaco at uls.co.za>
Gerrit-Comment-Date: Wed, 10 Nov 2021 13:51:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211110/c8c9b6ae/attachment-0001.html>