[Asterisk-code-review] func_evalexten: Extension evaluation function (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A, Sarah Autumn, George Joseph.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16075 )

Change subject: func_evalexten: Extension evaluation function
......................................................................


Patch Set 12: Code-Review-1

(1 comment)

File funcs/func_evalexten.c:

https://gerrit.asterisk.org/c/asterisk/+/16075/comment/1a65b7d1_08a127f3 
PS12, Line 157: 	pbx_substitute_variables_helper(chan, tmpbuf, buf, len);
What will happen if ast_async_goto is called on the channel here while the lock isn't held? I believe that the context, extension, and priority will be changed to the new location - which will then immediately be overwritten afterwards to the old value resulting in the ast_async_goto failing silently.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16075
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iad81019689674c9f4ac77d235f5d7234adbb1432
Gerrit-Change-Number: 16075
Gerrit-PatchSet: 12
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 10 Nov 2021 13:21:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211110/eeaf6e6e/attachment.html>