[Asterisk-code-review] BuildSystem: Consistently allow 'ye' even for Jansson. (asterisk[master])

George Joseph asteriskteam at digium.com
Tue Nov 9 08:21:52 CST 2021


Attention is currently required from: Alexander Traud.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17328 )

Change subject: BuildSystem: Consistently allow 'ye' even for Jansson.
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1: 
> Surprisingly, all AC_PATH_TOOL usages get changed. Looking at the description of that macro <http://www.gnu.org/software/autoconf/manual/html_node/Generic-Programs.html>, I do not think this is the correct macro and AC_PROG_TOOL should be used instead. Any comments?

I don't think AC_PROG_TOOL exists.  Did you mean AC_PATH_PROG?  If so, then yeah. AC_PATH_PROG is better for uname.  The TOOL macros are usually used for things like the compiler and linker which can have architecture prefixes like x86_64-redhat-linux- or aarch64-linux-gnu-.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17328
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I0c80c76d2cc98b0e5c859131290f4e3141a1a544
Gerrit-Change-Number: 17328
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Comment-Date: Tue, 09 Nov 2021 14:21:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alexander Traud <pabstraud at compuserve.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211109/cb4efffa/attachment.html>


More information about the asterisk-code-review mailing list