[Asterisk-code-review] BuildSystem: In POSIX sh, == in place of = is undefined. (asterisk[18])

George Joseph asteriskteam at digium.com
Mon Nov 8 13:42:27 CST 2021


George Joseph has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/16692 )

Change subject: BuildSystem: In POSIX sh, == in place of = is undefined.
......................................................................

BuildSystem: In POSIX sh, == in place of = is undefined.

ASTERISK-29724

Change-Id: I59aa0e52effdc16992f3a736ccf73430a6ef135b
---
M configure
M configure.ac
2 files changed, 6 insertions(+), 6 deletions(-)

Approvals:
  Sean Bright: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved; Approved for Submit



diff --git a/configure b/configure
index 90abf07..40aa43b 100755
--- a/configure
+++ b/configure
@@ -9217,7 +9217,7 @@
 fi
 
 
-if test "${with_pjproject}" == "no" || test "${with_pjproject}" == "n" ; then
+if test "${with_pjproject}" = "no" || test "${with_pjproject}" = "n" ; then
 	PJPROJECT_BUNDLED=no
 fi
 
@@ -9306,7 +9306,7 @@
 # If neither --without-ssl (PBX_OPENSSL=-1) nor --without-crypto (PBX_CRYPTO=-1)
 # and there were no directories atdded to --with-ssl and --with-crypto, and
 # pkg-config is installed (which is should be by install_prereq).
-if test "x$PKG_CONFIG" != "x" -a $PBX_OPENSSL -ge 0 -a $PBX_CRYPTO -ge 0 -a "x$OPENSSL_DIR" == "x" ; then
+if test "x$PKG_CONFIG" != "x" -a $PBX_OPENSSL -ge 0 -a $PBX_CRYPTO -ge 0 -a "x$OPENSSL_DIR" = "x" ; then
 	{ $as_echo "$as_me:${as_lineno-$LINENO}: checking OPENSSL with pkg-config" >&5
 $as_echo "$as_me: checking OPENSSL with pkg-config" >&6;}
 	{ $as_echo "$as_me:${as_lineno-$LINENO}: checking whether system openssl > 1.1.0" >&5
@@ -15229,7 +15229,7 @@
 
 
 
-if test "${PERMANENT_DLOPEN}" == "yes"; then
+if test "${PERMANENT_DLOPEN}" = "yes"; then
 
 $as_echo "#define HAVE_PERMANENT_DLOPEN 1" >>confdefs.h
 
diff --git a/configure.ac b/configure.ac
index 11ade5f..6cecdf0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -456,7 +456,7 @@
 	      *) PJPROJECT_BUNDLED=yes ;;
 	esac])
 
-if test "${with_pjproject}" == "no" || test "${with_pjproject}" == "n" ; then
+if test "${with_pjproject}" = "no" || test "${with_pjproject}" = "n" ; then
 	PJPROJECT_BUNDLED=no
 fi
 
@@ -472,7 +472,7 @@
 # If neither --without-ssl (PBX_OPENSSL=-1) nor --without-crypto (PBX_CRYPTO=-1)
 # and there were no directories atdded to --with-ssl and --with-crypto, and
 # pkg-config is installed (which is should be by install_prereq).
-if test "x$PKG_CONFIG" != "x" -a $PBX_OPENSSL -ge 0 -a $PBX_CRYPTO -ge 0 -a "x$OPENSSL_DIR" == "x" ; then
+if test "x$PKG_CONFIG" != "x" -a $PBX_OPENSSL -ge 0 -a $PBX_CRYPTO -ge 0 -a "x$OPENSSL_DIR" = "x" ; then
 	AC_MSG_NOTICE(checking OPENSSL with pkg-config)
 	AC_MSG_NOTICE(checking whether system openssl > 1.1.0)
 	AST_PKG_CONFIG_CHECK([OPENSSL], [openssl >= 1.1.0])
@@ -782,7 +782,7 @@
 	esac], [PERMANENT_DLOPEN=no])
 
 AC_SUBST([PERMANENT_DLOPEN])
-if test "${PERMANENT_DLOPEN}" == "yes"; then
+if test "${PERMANENT_DLOPEN}" = "yes"; then
 	AC_DEFINE([HAVE_PERMANENT_DLOPEN], 1, [Define to support libc with permanent dlopen.])
 fi
 

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16692
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I59aa0e52effdc16992f3a736ccf73430a6ef135b
Gerrit-Change-Number: 16692
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211108/5dbaaefd/attachment.html>


More information about the asterisk-code-review mailing list