[Asterisk-code-review] app_voicemail: Refactor email generation functions (asterisk[master])

[N A]

Attention is currently required from: Sean Bright, Joshua Colp, Stanislav Abramenkov, George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16665 )

Change subject: app_voicemail: Refactor email generation functions
......................................................................


Patch Set 8:

(3 comments)

Patchset:

PS8: 
> some errors in the latest revision: […]
Done


File apps/app_voicemail.c:

https://gerrit.asterisk.org/c/asterisk/+/16665/comment/7f475a0a_1b63b1cf 
PS5, Line 542: #ifdef IMAP_STORAGE
             : #define ENDL "\r\n"
             : #else
             : #define ENDL "\n"
             : #endif
> Before your patch, the base64 encoding would use the ENDL defined here. Now it will only use \n. […]
Done


File main/utils.c:

https://gerrit.asterisk.org/c/asterisk/+/16665/comment/ff498ff8_efa45e34 
PS5, Line 652: int ast_file_base_encode(char *filename, FILE *so)
> This is the same API as it was, I didn't change it. […]
Ack



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16665
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I1de0ed3483623e9599711129edc817c45ad237ee
Gerrit-Change-Number: 16665
Gerrit-PatchSet: 8
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 01 Nov 2021 22:18:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211101/cf5db2ae/attachment-0001.html>