[Asterisk-code-review] app_voicemail: Refactor email generation functions (asterisk[master])

[Sean Bright]

Attention is currently required from: N A, Joshua Colp, Stanislav Abramenkov, George Joseph.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16665 )

Change subject: app_voicemail: Refactor email generation functions
......................................................................


Patch Set 8: Code-Review-1

(1 comment)

Patchset:

PS8: 
some errors in the latest revision:

 16:34:05  utils.c: In function 'ast_file_base_encode':
 16:34:05  utils.c:698:5: error: too few arguments to function 'ochar'
 16:34:05       ochar(&bio, ogroup[i], so);
 16:34:05       ^
 16:34:05  utils.c:625:12: note: declared here
 16:34:05   static int ochar(struct baseio *bio, int c, FILE *so, char *endl)
 16:34:05              ^
 16:34:05  make[1]: *** [utils.o] Error 1



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16665
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I1de0ed3483623e9599711129edc817c45ad237ee
Gerrit-Change-Number: 16665
Gerrit-PatchSet: 8
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 01 Nov 2021 22:04:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211101/0d50998b/attachment.html>