[Asterisk-code-review] app_voicemail: Refactor email generation functions (asterisk[master])

[N A]

Attention is currently required from: Sean Bright, Joshua Colp, Stanislav Abramenkov, George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16665 )

Change subject: app_voicemail: Refactor email generation functions
......................................................................


Patch Set 2:

(2 comments)

Patchset:

PS2: 
> > I moved these to utils.h, don't they need to be in the header file? […]
Ah, I see what you mean.

These definitely are:
#define SENDMAIL "/usr/sbin/sendmail -t"
#define ENDL "\n"

I don't think the struct is, I'll move the other stuff over.


File include/asterisk/mail.h:

https://gerrit.asterisk.org/c/asterisk/+/16665/comment/a7b58e25_95267b9b 
PS1, Line 26: /usr/sbin/sendmail
> What about "contrib/scripts/install_prereq"? […]
Not sure if this makes any difference, but SENDMAIL is just a macro to the location of sendmail. Alternate mailers can be used, in theory.

It's not any more a pre-req now than it was with app_voicemail before.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16665
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I1de0ed3483623e9599711129edc817c45ad237ee
Gerrit-Change-Number: 16665
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 01 Nov 2021 19:16:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211101/a3a752cb/attachment-0001.html>