[Asterisk-code-review] app_voicemail: Refactor email generation functions (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16665 )

Change subject: app_voicemail: Refactor email generation functions
......................................................................


Patch Set 1: Code-Review-1

(6 comments)

Patchset:

PS1: 
> Okay, should all of these simply move there then, including the mkstemp function?
Yes, and there's additional comments.


File include/asterisk/mail.h:

https://gerrit.asterisk.org/c/asterisk/+/16665/comment/9c223fe7_c9a03a70 
PS1, Line 24: #define BASELINELEN 72
What do these mean within the context of the base encoding?


https://gerrit.asterisk.org/c/asterisk/+/16665/comment/ae4036b8_78dc4e38 
PS1, Line 36: int ast_base_encode(char *filename, FILE *so);
Needs a more explicit function name


https://gerrit.asterisk.org/c/asterisk/+/16665/comment/31862438_3cc96b06 
PS1, Line 40:  * \param template The template for the unique file name to generate
Should be documented that the filename is returned in here


File main/mail.c:

https://gerrit.asterisk.org/c/asterisk/+/16665/comment/5ff593fd_5f052cfb 
PS1, Line 131: 	while (!hiteof){
Can this reuse the existing base64 code at all?


https://gerrit.asterisk.org/c/asterisk/+/16665/comment/8bdef49c_ab153a49 
PS1, Line 178: 	chmod(template, VOICEMAIL_FILE_MODE & ~my_umask);
If this supports changing permissions then they should be passed in



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16665
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I1de0ed3483623e9599711129edc817c45ad237ee
Gerrit-Change-Number: 16665
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Mon, 01 Nov 2021 17:25:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211101/a99c8411/attachment.html>