[Asterisk-code-review] app_voicemail: Refactor email generation functions (asterisk[master])

N A asteriskteam at digium.com
Mon Nov 1 12:15:55 CDT 2021


Attention is currently required from: Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16665 )

Change subject: app_voicemail: Refactor email generation functions
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1: 
> That's the end goal of this change, but what other modules would include or need this? Are you plann […]
Well for one, app_mail (SendMail) would include it. There is a lot of overlap between the voicemail email code and that. So this allows reducing app_mail to just the module-specific stuff and not reinventing the wheel a bunch of times.
Anything else that needed to generate an email, for some reason, could also do so much more trivially now since it doesn't have to worry about the specific details in here.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16665
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I1de0ed3483623e9599711129edc817c45ad237ee
Gerrit-Change-Number: 16665
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 01 Nov 2021 17:15:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211101/d2235dea/attachment-0001.html>


More information about the asterisk-code-review mailing list