[Asterisk-code-review] app_waitforcond: New application (asterisk[16])

[N A]

Attention is currently required from: Richard Mudgett.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15928 )

Change subject: app_waitforcond: New application
......................................................................


Patch Set 5:

(2 comments)

File apps/app_waitforcond.c:

https://gerrit.asterisk.org/c/asterisk/+/15928/comment/807731dd_3b9dfeb1 
PS4, Line 101: 	char *tmp, *open_bracket, *expression, *optargs = NULL;
> tmp is always a lousy variable name.  All variables are temporary. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/15928/comment/2d2572fa_f7490e81 
PS4, Line 205: 	while (1) {
> It has occurred to me that there is no exit from this loop if chan itself hangs up while it is waiti […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15928
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I08adf2824b8bc63405778cf355963b5005612f41
Gerrit-Change-Number: 15928
Gerrit-PatchSet: 5
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 28 May 2021 17:28:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Richard Mudgett <rmudgett at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210528/ccf4b9fb/attachment.html>