[Asterisk-code-review] app_waitforcond: New application (asterisk[16])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15928 )

Change subject: app_waitforcond: New application
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

This should have a testsuite test that exercises the app. See the 'waitdigit' test found under the Asterisk testsuite repo (tests/apps/waitdigit/) for an example of how a test for this could be patterned.

https://gerrit.asterisk.org/c/asterisk/+/15928/3/apps/app_waitforcond.c 
File apps/app_waitforcond.c:

https://gerrit.asterisk.org/c/asterisk/+/15928/3/apps/app_waitforcond.c@55 
PS3, Line 55: 			<parameter name="timeout" />
            : 			<parameter name="interval" />
Think this one got missed. Add to the descriptions for these parameters what time unit they are in (e.g. seconds), and whether or not fractional values are excepted (e.g. 1.53 seconds)



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15928
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I08adf2824b8bc63405778cf355963b5005612f41
Gerrit-Change-Number: 15928
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 26 May 2021 17:57:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210526/3c0e6d50/attachment.html>