[Asterisk-code-review] app_dial: Expanded A option to add caller announcement (asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15926 )

Change subject: app_dial: Expanded A option to add caller announcement
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/15926/4/apps/app_dial.c 
File apps/app_dial.c:

https://gerrit.asterisk.org/c/asterisk/+/15926/4/apps/app_dial.c@2993 
PS4, Line 2993: 				active_chan_peer = ast_waitfor_n(chans, 2, &mspeer);
You can't do this. The ast_waitfor_n waits for either frames from the channels, or for the amount of time to have passed. By calling it twice you are extending the time that things wait for.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15926
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: If6eed3ff5c341dc8c588c8210987f2571e891e5e
Gerrit-Change-Number: 15926
Gerrit-PatchSet: 4
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 26 May 2021 17:43:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210526/ab49700c/attachment.html>