[Asterisk-code-review] app_waitforcond: New application (asterisk[16])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15928 )

Change subject: app_waitforcond: New application
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/c/asterisk/+/15928/2/apps/app_waitforcond.c 
File apps/app_waitforcond.c:

https://gerrit.asterisk.org/c/asterisk/+/15928/2/apps/app_waitforcond.c@103 
PS2, Line 103: 		ast_log(LOG_ERROR, "Channel already gone\n");
This message is misleading.  The application is running on this channel.  If it does not exist it is a bug.
"Application does not have a channel\n"


https://gerrit.asterisk.org/c/asterisk/+/15928/2/apps/app_waitforcond.c@104 
PS2, Line 104: 		return 0;
Actually, this really should return -1.  The application being run without a channel is a bad condition.  I would go so far as it being not possible since dialplan can only run on a channel.


https://gerrit.asterisk.org/c/asterisk/+/15928/2/apps/app_waitforcond.c@199 
PS2, Line 199: 	
whitespace



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15928
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I08adf2824b8bc63405778cf355963b5005612f41
Gerrit-Change-Number: 15928
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 26 May 2021 01:04:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210525/03ad9c6c/attachment.html>