[Asterisk-code-review] app_waitforcond: New application (asterisk[16])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15928 )

Change subject: app_waitforcond: New application
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/15928/1/apps/app_waitforcond.c 
File apps/app_waitforcond.c:

https://gerrit.asterisk.org/c/asterisk/+/15928/1/apps/app_waitforcond.c@82 
PS1, Line 82: static int waitforcond_exec(struct ast_channel *chan, const char *data)
> Some of the failures paths return 0, while others return -1. Should all return -1? […]
You only want to return non-zero(-1) for applications if an error should be hanging up the call.  Therefor, you only want to disconnect the call on dialplan errors that must be fixed not normal runtime failure conditions that need to be handled by the dialplan.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15928
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I08adf2824b8bc63405778cf355963b5005612f41
Gerrit-Change-Number: 15928
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 25 May 2021 22:56:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210525/acfc71d3/attachment.html>