[Asterisk-code-review] STIR/SHAKEN: Add Date header, dest->tn, and URL checking. (asterisk[16])

Joshua Colp asteriskteam at digium.com
Mon May 24 11:46:30 CDT 2021


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15920 )

Change subject: STIR/SHAKEN: Add Date header, dest->tn, and URL checking.
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

Just a minor tweak.

https://gerrit.asterisk.org/c/asterisk/+/15920/2/include/asterisk/res_pjsip.h 
File include/asterisk/res_pjsip.h:

https://gerrit.asterisk.org/c/asterisk/+/15920/2/include/asterisk/res_pjsip.h@953 
PS2, Line 953:  */
This should have \since to specify the versions it showed up in since it's a public API. Also document the behavior if this is called multiple times.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15920
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Idee5b1b5e45bc3b483b3070e46ce322dca5b3f1c
Gerrit-Change-Number: 15920
Gerrit-PatchSet: 2
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 24 May 2021 16:46:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210524/1d10e2fe/attachment.html>


More information about the asterisk-code-review mailing list