[Asterisk-code-review] func_channel: Added new OTHER_CHANNEL function (asterisk[16])

N A asteriskteam at digium.com
Mon May 24 08:32:17 CDT 2021


N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15908 )

Change subject: func_channel: Added new OTHER_CHANNEL function
......................................................................


Patch Set 6:

> Patch Set 6: Code-Review-2
> 
> At this point, we're really not comfortable with this change from both the security and stability aspect as well as the locking aspect.  If you want to go forward with this, we'd like to see two things...  Some way to limit the other channels to those involved in the call, and a good set of tests that can make sure there are no locking issues as well as making sure that you can't escape the set of valid channels.

What would the other channels in the call need to be limited to? Any channel part of the same "stack" of channels as Side A or B, or more or less permissive than that?


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15908
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I7492645ae4307553d0f586d78e13a4f586231fdf
Gerrit-Change-Number: 15908
Gerrit-PatchSet: 6
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 24 May 2021 13:32:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210524/2a7153b2/attachment.html>


More information about the asterisk-code-review mailing list