[Asterisk-code-review] func_math: Three new dialplan functions (asterisk[16])

George Joseph asteriskteam at digium.com
Mon May 24 07:22:52 CDT 2021


George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15906 )

Change subject: func_math: Three new dialplan functions
......................................................................


Patch Set 8: Code-Review-1

(3 comments)

Just a thought...  Since the other math functions can operate on doubles, so yo want to make these work on doubles as well?

https://gerrit.asterisk.org/c/asterisk/+/15906/8/funcs/func_math.c 
File funcs/func_math.c:

https://gerrit.asterisk.org/c/asterisk/+/15906/8/funcs/func_math.c@501 
PS8, Line 501: 	
Whitespace


https://gerrit.asterisk.org/c/asterisk/+/15906/8/funcs/func_math.c@513 
PS8, Line 513: 	
Whitespace


https://gerrit.asterisk.org/c/asterisk/+/15906/8/funcs/func_math.c@555 
PS8, Line 555: 	
Whitespace



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15906
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I2bda9269d18f9d54833c85e48e41fce0e0ce4d8d
Gerrit-Change-Number: 15906
Gerrit-PatchSet: 8
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Ivan Poddubny <ivan.poddubny at gmail.com>
Gerrit-Comment-Date: Mon, 24 May 2021 12:22:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210524/2c7e944a/attachment.html>


More information about the asterisk-code-review mailing list