[Asterisk-code-review] res_pjsip.c: Support endpoints with domain info in username (asterisk[16])

[Joe]

Joe has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15896 )

Change subject: res_pjsip.c: Support endpoints with domain info in username
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> > Patch Set 1:
> > 
> > > Patch Set 1:
> > > 
> > > > Patch Set 1:
> > > > 
> > > > Can you provide an example of what this looks like from a configuration perspective?
> > > 
> > > Ah, there's one on the issue.
> > 
> > Yes.
> > 
> > I am unsure if the patch I'm suggesting is a bandaid approach, because it may be smarter to have PJSIP sorcery pull up user as the part before the @, and fromdomain as whats to the right of the @ for the entire project.  Thoughts?  I can upload another patchset addressing that but it didn't work for me.
> 
> Things... don't work like that.

No problem.

My point just was that if in your opinion this patch isn't really addressing the underlying issue I can post another patch on JIRA and maybe others can help tweak.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15896
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I96f8d01dfdd5573ba7a28299e46271dd4210b619
Gerrit-Change-Number: 15896
Gerrit-PatchSet: 1
Gerrit-Owner: Joe <ynadiv at corpit.xyz>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 20 May 2021 17:27:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210520/b2cbb3fd/attachment.html>