[Asterisk-code-review] func_channel: Added new OTHER_CHANNEL function (asterisk[16])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15908 )

Change subject: func_channel: Added new OTHER_CHANNEL function
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/15908/5/funcs/func_ochannel.c 
File funcs/func_ochannel.c:

https://gerrit.asterisk.org/c/asterisk/+/15908/5/funcs/func_ochannel.c@92 
PS5, Line 92: 	ast_str_substitute_variables(buf, len, ochan, output);
> No lock is needed as the function will obtain the lock.  The currently held chan ref is sufficient.
For some silly reason I had looked at the function by the same name in extconf.c. Indeed the actual function called here locks the channel.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15908
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I7492645ae4307553d0f586d78e13a4f586231fdf
Gerrit-Change-Number: 15908
Gerrit-PatchSet: 6
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 20 May 2021 14:54:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Comment-In-Reply-To: Richard Mudgett <rmudgett at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210520/5c3b7220/attachment.html>