[Asterisk-code-review] res_rtp_asterisk: Set correct raddr port on RTCP srflx candidates. (asterisk[master])

[Joshua Colp]

Joshua Colp has uploaded this change for review. ( https://gerrit.asterisk.org/c/asterisk/+/15914 )


Change subject: res_rtp_asterisk: Set correct raddr port on RTCP srflx candidates.
......................................................................

res_rtp_asterisk: Set correct raddr port on RTCP srflx candidates.

RTCP ICE candidates use a base address derived from the RTP
candidate. The port on the base address was not being updated to
the RTCP port.

This change sets the base port to the RTCP port and all is well.

ASTERISK-29433

Change-Id: Ide2d2115b307bfd3c2dfbc4d187515d724519040
---
M res/res_rtp_asterisk.c
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/14/15914/1

diff --git a/res/res_rtp_asterisk.c b/res/res_rtp_asterisk.c
index 20504cb..bf98c22 100644
--- a/res/res_rtp_asterisk.c
+++ b/res/res_rtp_asterisk.c
@@ -3682,6 +3682,7 @@
 			ao2_iterator_destroy(&i);
 
 			if (srflx && baseset) {
+				pj_sockaddr_set_port(&base, port);
 				ast_rtp_ice_add_cand(instance, rtp, component, transport,
 					PJ_ICE_CAND_TYPE_SRFLX, 65535, &ext, &base, &base,
 					pj_sockaddr_get_len(&ext));

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15914
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ide2d2115b307bfd3c2dfbc4d187515d724519040
Gerrit-Change-Number: 15914
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210520/e896e188/attachment.html>