[Asterisk-code-review] func_channel: Added new OTHER_CHANNEL function (asterisk[16])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15908 )

Change subject: func_channel: Added new OTHER_CHANNEL function
......................................................................


Patch Set 5:

(2 comments)

https://gerrit.asterisk.org/c/asterisk/+/15908/5/funcs/func_ochannel.c 
File funcs/func_ochannel.c:

https://gerrit.asterisk.org/c/asterisk/+/15908/5/funcs/func_ochannel.c@92 
PS5, Line 92: 	ast_str_substitute_variables(buf, len, ochan, output);
> I'm thinking maybe since the channel is being arbitrarily obtained this needs a lock around it?
No lock is needed as the function will obtain the lock.  The currently held chan ref is sufficient.


https://gerrit.asterisk.org/c/asterisk/+/15908/5/funcs/func_ochannel.c@123 
PS5, Line 123: 
             : 	pbx_builtin_setvar_helper(ochan, data, value);
> I'm thinking maybe since the channel is being arbitrarily obtained this needs a lock around it?
Same for similar comment above.  Lock is not needed.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15908
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I7492645ae4307553d0f586d78e13a4f586231fdf
Gerrit-Change-Number: 15908
Gerrit-PatchSet: 5
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 20 May 2021 00:14:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210519/7a0847f5/attachment-0001.html>