[Asterisk-code-review] res_pjsip_outbound_authenticator_digest: Be tolerant of RFC8760 UASs (asterisk[16])

Kevin Harwell asteriskteam at digium.com
Wed May 19 17:30:35 CDT 2021


Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15764 )

Change subject: res_pjsip_outbound_authenticator_digest: Be tolerant of RFC8760 UASs
......................................................................


Patch Set 7: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/c/asterisk/+/15764/7/res/res_pjsip_outbound_authenticator_digest.c 
File res/res_pjsip_outbound_authenticator_digest.c:

https://gerrit.asterisk.org/c/asterisk/+/15764/7/res/res_pjsip_outbound_authenticator_digest.c@43 
PS7, Line 43: dependging
s/dependging/depending


https://gerrit.asterisk.org/c/asterisk/+/15764/7/res/res_pjsip_outbound_authenticator_digest.c@90 
PS7, Line 90: Autnenticate
s/Autnenticate/Authenticate


https://gerrit.asterisk.org/c/asterisk/+/15764/7/res/res_pjsip_outbound_authenticator_digest.c@129 
PS7, Line 129: 		struct ast_str *realms)
When appending, an ast_str can potentially be reallocated, so this should be passed in as a pointer to a pointer or **realms



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15764
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I3aef5ce4fe1d27e48d61268520f284d15d650281
Gerrit-Change-Number: 15764
Gerrit-PatchSet: 7
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Wed, 19 May 2021 22:30:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210519/b7a0b8c2/attachment.html>


More information about the asterisk-code-review mailing list