[Asterisk-code-review] func_minmax: Two new dialplan functions (asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15906 )

Change subject: func_minmax: Two new dialplan functions
......................................................................


Patch Set 5:

(1 comment)

> Patch Set 5:
> 
> (1 comment)
> 
> Are there benefits in creating a new module only for MIN and MAX?
> What do you think about adding them to func_math.c instead?

The only real benefit is being able to independently specify the support level of the module itself, while in func_math it would then fall under core supported and Sangoma would be responsible. I guess these are small and simple enough that they could go there.

https://gerrit.asterisk.org/c/asterisk/+/15906/5/funcs/func_minmax.c 
File funcs/func_minmax.c:

https://gerrit.asterisk.org/c/asterisk/+/15906/5/funcs/func_minmax.c@4 
PS5, Line 4:  * Copyright (C) 2021, Digium, Inc.
> Shouldn't this be Sangoma Technologies Corporation?
Yes, good find. My brain mentally replaces it these days in most things - ha.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15906
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I2bda9269d18f9d54833c85e48e41fce0e0ce4d8d
Gerrit-Change-Number: 15906
Gerrit-PatchSet: 5
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Ivan Poddubny <ivan.poddubny at gmail.com>
Gerrit-Comment-Date: Wed, 19 May 2021 21:22:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ivan Poddubny <ivan.poddubny at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210519/4ff7ab57/attachment.html>