[Asterisk-code-review] res_pjsip_dialog_info_body_generator: Add LOCAL/REMOTE tags in dialog... (asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15763 )

Change subject: res_pjsip_dialog_info_body_generator: Add LOCAL/REMOTE tags in dialog-info+xml
......................................................................


Patch Set 15:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/15763/15/res/res_pjsip_dialog_info_body_generator.c 
File res/res_pjsip_dialog_info_body_generator.c:

https://gerrit.asterisk.org/c/asterisk/+/15763/15/res/res_pjsip_dialog_info_body_generator.c@242 
PS15, Line 242: 		if (state_data->device_state_info) {
> Thanks so much for stepping in to fill in my knowledge gaps. […]
In the PUBLISH scenario (where Asterisk is publishing the state elsewhere without a subscription), device_state_info is NULL. Since this change was targeted for subscriptions I opted to not add the local bits even on PUBLISH to maintain existing XML behavior for that scenario.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15763
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I20c5cf5b45f34d7179df6573c5abf863eb72964b
Gerrit-Change-Number: 15763
Gerrit-PatchSet: 15
Gerrit-Owner: Joe <ynadiv at corpit.xyz>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Comment-Date: Wed, 19 May 2021 13:52:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joe <ynadiv at corpit.xyz>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210519/604c67f6/attachment.html>