[Asterisk-code-review] func_channel: Added new OTHER_CHANNEL function (asterisk[16])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15908 )

Change subject: func_channel: Added new OTHER_CHANNEL function
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.asterisk.org/c/asterisk/+/15908/3/funcs/func_ochannel.c 
File funcs/func_ochannel.c:

https://gerrit.asterisk.org/c/asterisk/+/15908/3/funcs/func_ochannel.c@91 
PS3, Line 91: 	sprintf(output, "${%s}", data); /* SAFE */
snprintf() takes a parameter for the size of the output buffer which ensures that it can never write outside of the buffer.  In this case the size parameter is the same as what you provided to ast_alloca() since output is allocated and not a fixed character array.


https://gerrit.asterisk.org/c/asterisk/+/15908/3/funcs/func_ochannel.c@114 
PS3, Line 114: 	if (!(ochan = ast_channel_get_by_name(args.channel))) {
Same here about assignment in the if expression



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15908
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I7492645ae4307553d0f586d78e13a4f586231fdf
Gerrit-Change-Number: 15908
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 17 May 2021 17:17:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210517/3d70bb5f/attachment.html>