[Asterisk-code-review] func_minmax: Two new dialplan functions (asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15906 )

Change subject: func_minmax: Two new dialplan functions
......................................................................


Patch Set 5: -Code-Review

> Patch Set 5:
> 
> > Patch Set 4:
> > 
> > Additionally - dialplan expressions should already support doing this stuff:
> > 
> > exten => s,1,Set(NUM=4)
> > exten => s,n,NoOp($[$[${NUM} > 5] ? 5 :: ${NUM}])
> > 
> > If ${NUM} is greater than 5, then the expression will return 5 otherwise it returns ${NUM}
> 
> True, but with several nested MIN/MAX statements and other logic, an actual function for these can make dialplan code much cleaner and easier to follow.

I'll remove my -1 and others can chime in.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15906
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I2bda9269d18f9d54833c85e48e41fce0e0ce4d8d
Gerrit-Change-Number: 15906
Gerrit-PatchSet: 5
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 17 May 2021 14:46:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210517/ec6c114c/attachment.html>