[Asterisk-code-review] func_minmax: Two new dialplan functions (asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15906 )

Change subject: func_minmax: Two new dialplan functions
......................................................................


Patch Set 4: Code-Review-1

(5 comments)

https://gerrit.asterisk.org/c/asterisk/+/15906/4/funcs/func_minmax.c 
File funcs/func_minmax.c:

https://gerrit.asterisk.org/c/asterisk/+/15906/4/funcs/func_minmax.c@30 
PS4, Line 30: 	<support_level>core</support_level>
This should be extended support.


https://gerrit.asterisk.org/c/asterisk/+/15906/4/funcs/func_minmax.c@82 
PS4, Line 82: 	if (ast_strlen_zero(args.num1) || sscanf(args.num1, "%30d", &int1) != 1)
This doesn't follow the coding guidelines[1].

[1] https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines#CodingGuidelines-Ifstatements:


https://gerrit.asterisk.org/c/asterisk/+/15906/4/funcs/func_minmax.c@134 
PS4, Line 134: 	
Redness


https://gerrit.asterisk.org/c/asterisk/+/15906/4/funcs/func_minmax.c@144 
PS4, Line 144: 	
Redness


https://gerrit.asterisk.org/c/asterisk/+/15906/4/funcs/func_minmax.c@147 
PS4, Line 147: 	
Redness



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15906
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I2bda9269d18f9d54833c85e48e41fce0e0ce4d8d
Gerrit-Change-Number: 15906
Gerrit-PatchSet: 4
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 17 May 2021 14:30:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210517/b4c280bb/attachment-0001.html>