[Asterisk-code-review] func_min and func_max: Two new dialplan functions (asterisk[master])

N A asteriskteam at digium.com
Mon May 17 08:36:17 CDT 2021


N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15892 )

Change subject: func_min and func_max: Two new dialplan functions
......................................................................


Patch Set 2:

> Patch Set 2: Code-Review-1
> 
> (1 comment)
> 
> You can have both dialplan functions in the same source file.  func_minmax.c

I'll merge the files in a second.
Does your other comment mean "Digium, Inc" should not be on line 4 at all?

I looked through files and I typically see Digium listed, e.g.
func_rand.c has Digium and the author listed. I followed the structure of func_rand for this.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15892
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I2bda9269d18f9d54833c85e48e41fce0e0ce4d8d
Gerrit-Change-Number: 15892
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 17 May 2021 13:36:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210517/90c0fc86/attachment.html>


More information about the asterisk-code-review mailing list