[Asterisk-code-review] func_min and func_max: Two new dialplan functions (asterisk[master])

Richard Mudgett asteriskteam at digium.com
Mon May 17 07:45:17 CDT 2021


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15892 )

Change subject: func_min and func_max: Two new dialplan functions
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.asterisk.org/c/asterisk/+/15892/1/funcs/func_max.c 
File funcs/func_max.c:

https://gerrit.asterisk.org/c/asterisk/+/15892/1/funcs/func_max.c@1 
PS1, Line 1: /*
This file uses CR/LF line terminators.  Should be using linux LF line terminators.  Also both this file and func_min.c are missing the line terminator on the last line.


https://gerrit.asterisk.org/c/asterisk/+/15892/1/funcs/func_max.c@72 
PS1, Line 72: 	
red blob. (trailing whitespace)


https://gerrit.asterisk.org/c/asterisk/+/15892/1/funcs/func_min.c 
File funcs/func_min.c:

https://gerrit.asterisk.org/c/asterisk/+/15892/1/funcs/func_min.c@72 
PS1, Line 72: 	
red blob



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15892
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I2bda9269d18f9d54833c85e48e41fce0e0ce4d8d
Gerrit-Change-Number: 15892
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 17 May 2021 12:45:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210517/f6e6bb86/attachment.html>


More information about the asterisk-code-review mailing list