[Asterisk-code-review] STIR/SHAKEN: Switch to base64 URL encoding. (asterisk[16])

[Benjamin Keith Ford]

Benjamin Keith Ford has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15848 )

Change subject: STIR/SHAKEN: Switch to base64 URL encoding.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/15848/2/main/utils.c 
File main/utils.c:

https://gerrit.asterisk.org/c/asterisk/+/15848/2/main/utils.c@73 
PS2, Line 73: static char base64[64];
            : static char base64url[64];
            : static char b2a[256];
            : static char b2a_url[256];
> Shouldn't these be in thread local storage?  Otherwise 2 threads could be trying to access it at the […]
These have consistent data in them - they are never changed once initialized (by base64_init). They basically serve as a library / dictionary that gets pulled from when encoding and decoding. So there's no issue with things trying to access at the same time.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15848
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Icf094a2a54e87db91d6b12244c9f5ba4fc2e0b8c
Gerrit-Change-Number: 15848
Gerrit-PatchSet: 2
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 03 May 2021 14:16:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210503/20f80f90/attachment.html>