[Asterisk-code-review] res_pjsip/pjsip_message_filter: set preferred transport in pjsip_mess... (asterisk[16])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15630 )

Change subject: res_pjsip/pjsip_message_filter: set preferred transport in pjsip_message_filter
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/15630/5/res/res_pjsip/pjsip_message_filter.c 
File res/res_pjsip/pjsip_message_filter.c:

https://gerrit.asterisk.org/c/asterisk/+/15630/5/res/res_pjsip/pjsip_message_filter.c@242 
PS5, Line 242: if ((tdata->tp_info.transport->key.type != PJSIP_TRANSPORT_UDP) &&
             : 		(tdata->tp_info.transport->key.type != PJSIP_TRANSPORT_UDP6)) {
             : 		sel.type = PJSIP_TPSELECTOR_LISTENER;
             : 		sel.u.listener = tdata->tp_info.transport->factory;
             : 		prm.tp_sel = &sel;
             : 	}
Are we sure this works for both outgoing requests and outgoing responses?
-1'ing just to get your attention.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15630
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I598e60257a7f92b29efce1fb3e9a2fc06f1439b6
Gerrit-Change-Number: 15630
Gerrit-PatchSet: 5
Gerrit-Owner: Florian Floimair <f.floimair at commend.com>
Gerrit-Reviewer: Bernd Zobl <b.zobl at commend.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 03 May 2021 11:51:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210503/f1afb0c0/attachment.html>