[Asterisk-code-review] res_pjsip_header_funcs: Add PJSIP_HEADERS() ability to read header by... (asterisk[master])

[Igor Goncharovsky]

Igor Goncharovsky has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15761 )

Change subject: res_pjsip_header_funcs: Add PJSIP_HEADERS() ability to read header by pattern
......................................................................


Patch Set 3:

(9 comments)

https://gerrit.asterisk.org/c/asterisk/+/15761/1/res/res_pjsip_header_funcs.c 
File res/res_pjsip_header_funcs.c:

https://gerrit.asterisk.org/c/asterisk/+/15761/1/res/res_pjsip_header_funcs.c@310 
PS1, Line 310: 			
> Redness
Ack


https://gerrit.asterisk.org/c/asterisk/+/15761/3/res/res_pjsip_header_funcs.c 
File res/res_pjsip_header_funcs.c:

https://gerrit.asterisk.org/c/asterisk/+/15761/3/res/res_pjsip_header_funcs.c@288 
PS3, Line 288: 	si
> The function pjsip_hdr_print_on returns int, not size_t
Ack


https://gerrit.asterisk.org/c/asterisk/+/15761/3/res/res_pjsip_header_funcs.c@311 
PS3, Line 311: 			p
> 1. The size of the buffer should be data->len - 1 […]
Ack


https://gerrit.asterisk.org/c/asterisk/+/15761/3/res/res_pjsip_header_funcs.c@317 
PS3, Line 317: 				retu
> should we just skip the malformed header instead of return error?
Agree


https://gerrit.asterisk.org/c/asterisk/+/15761/3/res/res_pjsip_header_funcs.c@337 
PS3, Line 337: 			a
> > this will overwrites the data->buf, this should be data->len - wlen […]
Ack


https://gerrit.asterisk.org/c/asterisk/+/15761/3/res/res_pjsip_header_funcs.c@339 
PS3, Line 339: 		ast_copy_string(data->buf + wlen, ",", data->len);
> the same data->len - wlen
Ack


https://gerrit.asterisk.org/c/asterisk/+/15761/3/res/res_pjsip_header_funcs.c@344 
PS3, Line 344: 	if (!hdr) {
> should check wlen instead of hdr
Ack


https://gerrit.asterisk.org/c/asterisk/+/15761/3/res/res_pjsip_header_funcs.c@370 
PS3, Line 370: 	si
> The function pjsip_hdr_print_on returns int, not size_t
Ack


https://gerrit.asterisk.org/c/asterisk/+/15761/3/res/res_pjsip_header_funcs.c@406 
PS3, Line 406: 	p
> 1. The size of the buffer should be data->len - 1 […]
Ack



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15761
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ic09d395de71a0021e0d6c5c29e1e19d689079f8b
Gerrit-Change-Number: 15761
Gerrit-PatchSet: 3
Gerrit-Owner: Igor Goncharovsky <igor.goncharovsky at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Sat, 01 May 2021 16:52:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210501/6cb551db/attachment-0001.html>