[Asterisk-code-review] res_rtp_asterisk: Statically declare rtp_drop_packets_data struct (asterisk[16])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15723 )

Change subject: res_rtp_asterisk: Statically declare rtp_drop_packets_data struct
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/15723/1/res/res_rtp_asterisk.c 
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/c/asterisk/+/15723/1/res/res_rtp_asterisk.c@7563 
PS1, Line 7563:  { .num_to_drop = 0 }
I don't think you need to initialize it now but if you want to why not set the whole thing to { 0, }; ?
It might also be clearer if you define the structure separately, then declare drop_packets_data as static.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15723
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: If4f9b21fa0c47d41a35b6b05941d978efb4da87b
Gerrit-Change-Number: 15723
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 31 Mar 2021 19:23:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210331/574d80ce/attachment.html>