[Asterisk-code-review] res_speech_aeap: Add basic config skeleton and CLI commands. (asterisk[master])

[Benjamin Keith Ford]

Benjamin Keith Ford has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15699 )

Change subject: res_speech_aeap: Add basic config skeleton and CLI commands.
......................................................................


Patch Set 2:

> Patch Set 2:
> 
> > Patch Set 2:
> > 
> > If we want to keep this a generic external media module I'd recommend removing "speech" from all the function names and other references.
> 
> Maybe we should have a res module (this) which does the base of things, and then a res_speech module which uses that?

Yeah I think that would be good. This could just be res_aeap.c, read from aeap.conf, and then other modules can consume the configuration.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15699
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I567ac5148c92b98d29d2ad83421b416b75ffdaa3
Gerrit-Change-Number: 15699
Gerrit-PatchSet: 2
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 30 Mar 2021 17:21:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210330/ee26a048/attachment.html>