[Asterisk-code-review] pbx_variables: Fix parsing multiple = in Set command (asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15331 )

Change subject: pbx_variables: Fix parsing multiple = in Set command
......................................................................


Patch Set 3:

> Patch Set 3:
> 
> > Patch Set 3:
> > 
> > Sean Bright, Jaco Kroon: Would either of you like to take this on to update it?
> 
> Sure, can take a shot, but this is not even on my priority radar at all currently.
> 
> Did Leandro abandon this?  I honestly feel I'd rather have him finish this if possible, even if we do need to guide a bit.  It's been quiet for a month though ... so guessing one of us will have to take this over.

Ah he responded over email:

I am sorry, but currently I am on tight schedules, so I have no free time to dedicate at this issue. If you have someone able to take care of this issue, I'll be glad.

> 
> How thoroughly do you want this?  Ie, is it worthwhile to create a char parenthesis[] based stack to match different types of brackets and handle that as an error condition too, or is mere counting adequate?  Basically what I'm thinking is create a char parens[20]; paren_depth = 0;
> 
> When we encounter on of [({ we push it onto the stack (or error out if depth already == 20), and if we encounter ])} we pop and make sure match.
> 
> If we encounter = we ignore unless depth == 0.

I haven't looked into this so can't comment. I'm just doing Gerrit clean up and seeing where things stand.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15331
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I7cd3bc6118033530ad00ae4b6bdad97b6b349b6f
Gerrit-Change-Number: 15331
Gerrit-PatchSet: 3
Gerrit-Owner: Leandro Dardini <ldardini at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-CC: Jaco Kroon <jaco at uls.co.za>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 30 Mar 2021 09:25:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210330/e9c25584/attachment.html>