[Asterisk-code-review] t38_enabled_two_reinvite: Add missing dependency and fix run-test. (testsuite[16])

Joshua Colp asteriskteam at digium.com
Mon Mar 22 08:00:29 CDT 2021


Joshua Colp has uploaded this change for review. ( https://gerrit.asterisk.org/c/testsuite/+/15661 )


Change subject: t38_enabled_two_reinvite: Add missing dependency and fix run-test.
......................................................................

t38_enabled_two_reinvite: Add missing dependency and fix run-test.

These two tests require rtpdump which was not declared as a
dependency. They were also using ast_version functionality which
is no longer present, so the log message has been removed.

ASTERISK-29220

Change-Id: I09dd2a3988ec48c391185c576b75598ac706f946
---
M tests/fax/pjsip/t38_enabled_two_reinvite_on_a_leg/run-test
M tests/fax/pjsip/t38_enabled_two_reinvite_on_a_leg/test-config.yaml
M tests/fax/pjsip/t38_enabled_two_reinvite_on_b_leg/run-test
M tests/fax/pjsip/t38_enabled_two_reinvite_on_b_leg/test-config.yaml
4 files changed, 2 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/61/15661/1

diff --git a/tests/fax/pjsip/t38_enabled_two_reinvite_on_a_leg/run-test b/tests/fax/pjsip/t38_enabled_two_reinvite_on_a_leg/run-test
index cd10049..88012e9 100755
--- a/tests/fax/pjsip/t38_enabled_two_reinvite_on_a_leg/run-test
+++ b/tests/fax/pjsip/t38_enabled_two_reinvite_on_a_leg/run-test
@@ -60,7 +60,6 @@
 
 def main():
     test = SIPpTest(WORKING_DIR, TEST_DIR, SIPP_SCENARIOS)
-    logger.info ("Running against asterisk version %s" %test.ast_version)
 		   
     test.reactor_timeout = 100;
 
diff --git a/tests/fax/pjsip/t38_enabled_two_reinvite_on_a_leg/test-config.yaml b/tests/fax/pjsip/t38_enabled_two_reinvite_on_a_leg/test-config.yaml
index abd9400..3960586 100644
--- a/tests/fax/pjsip/t38_enabled_two_reinvite_on_a_leg/test-config.yaml
+++ b/tests/fax/pjsip/t38_enabled_two_reinvite_on_a_leg/test-config.yaml
@@ -8,6 +8,6 @@
     dependencies:
         - python : 'twisted'
         - python : 'starpy'
-
+        - app : 'rtpdump'
     tags:
         - SIP
diff --git a/tests/fax/pjsip/t38_enabled_two_reinvite_on_b_leg/run-test b/tests/fax/pjsip/t38_enabled_two_reinvite_on_b_leg/run-test
index 5de5b92..2ad1542 100755
--- a/tests/fax/pjsip/t38_enabled_two_reinvite_on_b_leg/run-test
+++ b/tests/fax/pjsip/t38_enabled_two_reinvite_on_b_leg/run-test
@@ -60,7 +60,6 @@
 
 def main():
     test = SIPpTest(WORKING_DIR, TEST_DIR, SIPP_SCENARIOS)
-    logger.info ("Running against asterisk version %s" %test.ast_version)
 		   
     test.reactor_timeout = 100;
 
diff --git a/tests/fax/pjsip/t38_enabled_two_reinvite_on_b_leg/test-config.yaml b/tests/fax/pjsip/t38_enabled_two_reinvite_on_b_leg/test-config.yaml
index abd9400..3960586 100644
--- a/tests/fax/pjsip/t38_enabled_two_reinvite_on_b_leg/test-config.yaml
+++ b/tests/fax/pjsip/t38_enabled_two_reinvite_on_b_leg/test-config.yaml
@@ -8,6 +8,6 @@
     dependencies:
         - python : 'twisted'
         - python : 'starpy'
-
+        - app : 'rtpdump'
     tags:
         - SIP

-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/15661
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 16
Gerrit-Change-Id: I09dd2a3988ec48c391185c576b75598ac706f946
Gerrit-Change-Number: 15661
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210322/d78d3f46/attachment.html>


More information about the asterisk-code-review mailing list