[Asterisk-code-review] res_pjsip_session: Make reschedule_reinvite check for NULL topologies (asterisk[certified/16.8])

George Joseph asteriskteam at digium.com
Fri Mar 19 13:11:35 CDT 2021


Hello Joshua Colp, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/15658

to look at the new patch set (#2).

Change subject: res_pjsip_session: Make reschedule_reinvite check for NULL topologies
......................................................................

res_pjsip_session: Make reschedule_reinvite check for NULL topologies

When the check for equal topologies was added to reschedule_reinvite()
it was assumed that both the pending and active media states would
actually have non-NULL topologies.  We since discovered this isn't
the case.

We now only test for equal topologies if both media states have
non-NULL topologies.  The logic had to be rearranged a bit to make
sure that we cloned the media states if their topologies were
non-NULL but weren't equal.

ASTERISK-29215

Change-Id: I61313cca7fc571144338aac826091791b87b6e17
---
M res/res_pjsip_session.c
1 file changed, 25 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/58/15658/2
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15658
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: certified/16.8
Gerrit-Change-Id: I61313cca7fc571144338aac826091791b87b6e17
Gerrit-Change-Number: 15658
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Friendly Automation
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210319/951679c8/attachment-0001.html>


More information about the asterisk-code-review mailing list