[Asterisk-code-review] res_pjsip/pjsip_message_filter: set preferred transport in pjsip_mess... (asterisk[16])

[Florian Floimair]

Florian Floimair has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15630 )

Change subject: res_pjsip/pjsip_message_filter: set preferred transport in pjsip_message_filter
......................................................................


Patch Set 2:

(1 comment)

> Patch Set 2:
> 
> > Patch Set 2:
> > 
> > > > So, if I resubmit this with me as the author, will you accept it? My boss does not want all developers to sign an agreement.
> > > 
> > > I would have to run it past the legal department, as it has clearly been shown that you are not the author. I have sent an email to them.
> > 
> > OK, thanks. I never meant to be rude. Just wanted to speed things up getting the fix in.
> > I hope your legal department has a quick answer, as we really want this fix upstreamed.
> 
> Per legal, unfortunately as I stated since we know that you are not the author even changing the submitter and wiping away the real author means we can't accept it without a signed license agreement from them.

OK, then my colleague will sign an agreement as well (also talked to my boss about this) and once this is done will resubmit it on his own behalf.
Hope your legal department is as fast processing the agreement as it was to answer this request. Thanks so far.

https://gerrit.asterisk.org/c/asterisk/+/15630/2/res/res_pjsip/pjsip_message_filter.c 
File res/res_pjsip/pjsip_message_filter.c:

https://gerrit.asterisk.org/c/asterisk/+/15630/2/res/res_pjsip/pjsip_message_filter.c@242 
PS2, Line 242: 	sel.type = PJSIP_TPSELECTOR_TRANSPORT;
> This should only be done if the existing transport is not UDP. […]
will do



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15630
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I598e60257a7f92b29efce1fb3e9a2fc06f1439b6
Gerrit-Change-Number: 15630
Gerrit-PatchSet: 2
Gerrit-Owner: Florian Floimair <f.floimair at commend.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 18 Mar 2021 14:49:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210318/44240092/attachment.html>