[Asterisk-code-review] menuselect: exit non-zero in case of failure on --enable|disable opti... (asterisk[master])

Jaco Kroon asteriskteam at digium.com
Thu Mar 18 03:26:02 CDT 2021


Jaco Kroon has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15628 )

Change subject: menuselect: exit non-zero in case of failure on --enable|disable options.
......................................................................


Patch Set 4:

> Patch Set 3: Code-Review+1
> 
> If you add a CHANGES entry that warns packagers that menuselect might fail now, you can cherry-pick to 16 and 18.

Done, please just check the wording/grammar, not a native english speaker and am not convinced my construction is clear and concise.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15628
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I77e3466435f5a51a57538b29addb68d811af238d
Gerrit-Change-Number: 15628
Gerrit-PatchSet: 4
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Thu, 18 Mar 2021 08:26:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210318/dce8bab8/attachment.html>


More information about the asterisk-code-review mailing list