[Asterisk-code-review] res_pjsip_messaging: Allow setting domain of recipient (asterisk[18])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15597 )

Change subject: res_pjsip_messaging: Allow setting domain of recipient
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/15597/3/res/res_pjsip_messaging.c 
File res/res_pjsip_messaging.c:

https://gerrit.asterisk.org/c/asterisk/+/15597/3/res/res_pjsip_messaging.c@232 
PS3, Line 232: 	parsed_name_addr = (pjsip_name_addr *) pjsip_parse_uri(tdata->pool, to, strlen(to),
> Such that you don't think this patch is usable?  Or are you implying perhaps that it's redundant, or somesuch?
> 
> Would you care to expand, for somebody who is not even a part-time Asterisk hacker, what the problem is that you see between MessageSend() being expanded to allow the domain of the the "to" field, for a pjsip "msg_tech" and chan_pjsip.c:sendtext()?

Oops, sorry I wasn't clear.  I thought we might have had the ability to set the actual "To:" header from the dialplan already using channel variables but I may be thinking of something else.   Let me investigate a bit.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15597
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I26fb8605d7cb200332a0442879fd9a5679a65022
Gerrit-Change-Number: 15597
Gerrit-PatchSet: 3
Gerrit-Owner: Brian J. Murrell <brian at interlinx.bc.ca>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 17 Mar 2021 13:05:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Comment-In-Reply-To: Brian J. Murrell <brian at interlinx.bc.ca>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210317/b5cdf334/attachment.html>