[Asterisk-code-review] xml: Embed module information into core XML documentation. (asterisk[16])

George Joseph asteriskteam at digium.com
Tue Mar 16 07:07:15 CDT 2021


George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15599 )

Change subject: xml: Embed module information into core XML documentation.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/15599/1/doc/appdocsxml.dtd 
File doc/appdocsxml.dtd:

https://gerrit.asterisk.org/c/asterisk/+/15599/1/doc/appdocsxml.dtd@14 
PS1, Line 14: <!ELEMENT module (depend*,use*,conflict*,defaultenabled?,support_level?,replacement?)>
Just noticed this...  We already use camelCase and '-' for multi-word identifiers.  Should use one of those (probably camelCase) rather than introducing another style.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15599
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ifbfd5c700049cf320a3e45351ac65dd89bc99d90
Gerrit-Change-Number: 15599
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 16 Mar 2021 12:07:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210316/e7a5b035/attachment.html>


More information about the asterisk-code-review mailing list