[Asterisk-code-review] res_pjsip_messaging: Allow setting domain of recipient (asterisk[18])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15597 )

Change subject: res_pjsip_messaging: Allow setting domain of recipient
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/15597/3/res/res_pjsip_messaging.c 
File res/res_pjsip_messaging.c:

https://gerrit.asterisk.org/c/asterisk/+/15597/3/res/res_pjsip_messaging.c@232 
PS3, Line 232: 	parsed_name_addr = (pjsip_name_addr *) pjsip_parse_uri(tdata->pool, to, strlen(to),
> Wait a second here.  "to" may or may not contain @domain.  Being able to contain @domain is what this patch is actually doing.  Before this patch, AFAIU, the "to"field of MessageSend() was only able to contain a bare endpoint name.

Take a look in chan_pjsip.c:sendtext() and in main/message.c.  A lot happens between the MessageSend dialplan app and res_pjsip_messaging.c.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15597
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I26fb8605d7cb200332a0442879fd9a5679a65022
Gerrit-Change-Number: 15597
Gerrit-PatchSet: 3
Gerrit-Owner: Brian J. Murrell <brian at interlinx.bc.ca>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Thu, 11 Mar 2021 16:01:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Brian J. Murrell <brian at interlinx.bc.ca>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210311/cfa652ad/attachment.html>