[Asterisk-code-review] loader: Output warnings for deprecated modules. (asterisk[16])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15625 )

Change subject: loader: Output warnings for deprecated modules.
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.asterisk.org/c/asterisk/+/15625/2/main/loader.c 
File main/loader.c:

https://gerrit.asterisk.org/c/asterisk/+/15625/2/main/loader.c@2429 
PS2, Line 2429: 			ast_str_append(&warning_msg, -1, ", it was deprecated in version '%s'", ast_xml_get_text(ast_xml_xpath_get_first_result(results)));
Not sure if it really matters all that much but the verbage here could change depending on the version. As in "it will be ...." vs "it was ....". Could probably get the current version and check against it, but may not be worth the effort.


https://gerrit.asterisk.org/c/asterisk/+/15625/2/main/loader.c@2435 
PS2, Line 2435: 			ast_str_append(&warning_msg, -1, ", it will be removed in version '%s'", ast_xml_get_text(ast_xml_xpath_get_first_result(results)));
Similar to above. Depending on the current version it could be "it will be ..." vs "it was ..."


https://gerrit.asterisk.org/c/asterisk/+/15625/2/main/loader.c@2441 
PS2, Line 2441: 			ast_str_append(&warning_msg, -1, ", it has been replaced by '%s'", ast_xml_get_text(ast_xml_xpath_get_first_result(results)));
Same. "it has been ..." vs "it will be ..."



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15625
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I2080dab97d2186be94c421b41dabf6d79a11611a
Gerrit-Change-Number: 15625
Gerrit-PatchSet: 2
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 10 Mar 2021 17:05:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210310/514276cd/attachment.html>