[Asterisk-code-review] res_pjsip_messaging: Allow setting domain of recipient (asterisk[18])

[Brian J. Murrell]

Brian J. Murrell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15597 )

Change subject: res_pjsip_messaging: Allow setting domain of recipient
......................................................................


Patch Set 3:

(2 comments)

> Patch Set 2:
> 
> This appears to be a legit issue:
> 
> 10:12:45  res_pjsip_messaging.c:242:2: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
> 10:12:45    char *domain = strchr(to, '@');

Fixed.

https://gerrit.asterisk.org/c/asterisk/+/15597/2//COMMIT_MSG 
Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/15597/2//COMMIT_MSG@15 
PS2, Line 15: This is a slight rework of a modification to my original patch for this
            : issue that was contributed to my open issue on this matter in
            : https://issues.asterisk.org/jira/browse/ASTERISK-28513.
> Actually, this paragraph is not even needed as it is off topic. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/15597/2/res/res_pjsip_messaging.c 
File res/res_pjsip_messaging.c:

https://gerrit.asterisk.org/c/asterisk/+/15597/2/res/res_pjsip_messaging.c@242 
PS2, Line 242: 	char *domain = strchr(to, '@');
> Yep, C does not allow declaring variables in the middle of a code block.
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15597
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I26fb8605d7cb200332a0442879fd9a5679a65022
Gerrit-Change-Number: 15597
Gerrit-PatchSet: 3
Gerrit-Owner: Brian J. Murrell <brian at interlinx.bc.ca>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 09 Mar 2021 17:27:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Richard Mudgett <rmudgett at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210309/f1c90c0d/attachment.html>